Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Add missing allowed_user_ids to role form in PKI into release/1.14.x #22242

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #22191 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


Description
Add allowed_user_ids under the Additional subject fields section of Create Role in PKI
Screenshot 2023-08-03 at 8 31 47 AM

Add user_ids under the Common name field in Generate Credentials in PKI
Screenshot 2023-08-08 at 9 11 51 AM

Confirmed with crypto (Alex + Steve) that it makes sense to place the fields in these sections/areas^


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-18721/add-missing-field-pki-role-form/eagerly-growing-starfish branch from 2c19a1b to 0d3355a Compare August 8, 2023 16:59
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-18721/add-missing-field-pki-role-form/eagerly-growing-starfish branch from b5f44fc to af0eb44 Compare August 8, 2023 16:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 8, 2023
@kiannaquach kiannaquach added this to the 1.14.2 milestone Aug 8, 2023
@kiannaquach kiannaquach added the ui label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

CI Results:
All Go tests succeeded! ✅

@kiannaquach kiannaquach merged commit 1c7f492 into release/1.14.x Aug 8, 2023
91 of 92 checks passed
@kiannaquach kiannaquach deleted the backport/ui/VAULT-18721/add-missing-field-pki-role-form/eagerly-growing-starfish branch August 8, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants