Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VAULT-17826] Remove mount point from rollback metrics #22400

Merged
merged 12 commits into from
Aug 21, 2023

Conversation

miagilepner
Copy link
Contributor

This PR creates two new metrics, vault.route.rollback and vault.rollback.attempt. These metrics replace the existing vault.route.rollback.{MOUNT_POINT} and vault.rollback.attempt.{MOUNT_POINT} metrics. By default, the metrics with the mount point in them are disabled, however they can be enabled with:

telemetry {
  add_mount_point_rollback_metrics = true
}

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 17, 2023
@miagilepner miagilepner changed the title Remove mount point from rollback metrics [VAULT-17826] Remove mount point from rollback metrics Aug 17, 2023
@miagilepner miagilepner added this to the 1.15 milestone Aug 17, 2023
@miagilepner miagilepner force-pushed the miagilepner/rollback-manager-metric branch from f586ebb to 9c62d02 Compare August 17, 2023 15:12
@miagilepner miagilepner marked this pull request as ready for review August 17, 2023 15:13
@miagilepner miagilepner requested a review from a team as a code owner August 17, 2023 15:13
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Nice docs and test improvements.

nit: Should we include some warning about the cardinality implications of enabling the mount-specific metrics in the docs?

miagilepner and others added 4 commits August 18, 2023 12:27
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Copy link
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc changes LGTM. Feel free to merge once the ENG review is complete

@miagilepner miagilepner merged commit 616c3a5 into main Aug 21, 2023
97 checks passed
@miagilepner miagilepner deleted the miagilepner/rollback-manager-metric branch August 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants