-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VAULT-17826] Remove mount point from rollback metrics #22400
Conversation
f586ebb
to
9c62d02
Compare
Build Results: |
CI Results: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice docs and test improvements.
nit: Should we include some warning about the cardinality implications of enabling the mount-specific metrics in the docs?
website/content/partials/telemetry-metrics/vault/rollback/attempt/mountpoint.mdx
Outdated
Show resolved
Hide resolved
website/content/partials/telemetry-metrics/vault/route/rollback/mountpoint.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes LGTM. Feel free to merge once the ENG review is complete
This PR creates two new metrics,
vault.route.rollback
andvault.rollback.attempt
. These metrics replace the existingvault.route.rollback.{MOUNT_POINT}
andvault.rollback.attempt.{MOUNT_POINT}
metrics. By default, the metrics with the mount point in them are disabled, however they can be enabled with: