ui: Wire up new KV ember engine to main app #22559
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
Signed-off-by: clairebontempo@gmail.com <clairebontempo@gmail.com>
ui/tests/acceptance/secrets/backend/kv/kv-v2-workflow-version-history-diff-test.js
Outdated
Show resolved
Hide resolved
| @@ -156,7 +157,9 @@ export default class MountBackendForm extends Component { | |||
| this.args.mountType === 'secret' ? 'secrets engine' : 'auth method' | |||
| } at ${path}.` | |||
| ); | |||
| yield this.args.onMountSuccess(type, path, mountModel); | |||
| // Check whether to use the engine route, since KV version 1 does not | |||
| .includesText( | ||
| 'custom_metadata validation failed: length of key', | ||
| 'shows API error that is not captured by validation' | ||
| module('mount and configure', function () { |
There was a problem hiding this comment.
To make clear which tests are for KV V1 vs V2 I separated into modules. The first module does not set up a secret engine on beforeEach
| this.server.shutdown(); | ||
| }); | ||
|
|
||
| test('it creates a secret and redirects', async function (assert) { |
There was a problem hiding this comment.
Removed -- tested be kv-v2 navigation workflow
| {{#each this.sortedDisplayableBackends as |backend|}} | ||
| <LinkedBlock | ||
| @params={{array backend.backendLink backend.id}} | ||
| class="list-item-row linked-block-item is-no-underline" | ||
| data-test-secrets-backend-link={{backend.id}} | ||
| @disabled={{if backend.isSupportedBackend false true}} | ||
| @disabled={{not backend.isSupportedBackend}} |
|
Build Results: |
|
CI Results: |
|
Does this new version remove the availability to view diffs between secret versions? |
|
We moved the diff to the create a new secret version view (screenshot below 📸 ). We thought comparing version diffs to be more useful when editing. However, if you were using diff comparison across versions, we'd love to know your use case and get feedback on this change. 😁 |
|
We are presently employing the 'diff' tool to contrast secret versions across different points in time. Occasionally, we encounter problematic deployments due to incorrect key-value (KV) settings, and it is important for us to pinpoint when this modification was initially introduced. Displaying the 'diff' at the time of creation is beneficial. Therefore, having both options, one at the moment of creation and the ability to compare any version, would be highly appreciated. Thank you. |
|
Thank you @marcportabellaclotet-mt for your incredibly helpful feedback! PR #23200 returns this functionality to the UI and we plan to ship it in the 1.15 GA release. The view will be located in the toolbar of the |
|
Incredible update! We greatly appreciate your attention to this feature. |
A new and improved KV V2 secret engine experience!
This PR switches the default KV view when version=2 to the work implemented in #22426.
Note: this change enforces URL updates for paths within a KV V2 secret engine. For example:
/ui/vault/secrets/kv-test/list->/ui/vault/secrets/kv-test/kv/list(this is automatically redirected)/ui/vault/secrets/kv-test/list/my/->/ui/vault/secrets/kv-test/kv/my%2F/directory/ui/vault/secrets/kv-test/show/my/nested-secret->/ui/vault/secrets/kv-test/kv/my%2Fnested-secret/details📸 New UI
