-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add worker pool for LDAP group lookup #22659
Conversation
Build Results: |
CI Results: |
Good stuff! Thanks for looking into the race. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement. Tagging @jimlambrt in case we want to port these changes to the cap/ldap package as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Thanks @jasonodonnell 👍
* Add worker pool for LDAP group lookup * changelog * Add lock * derefAliases disappeared
* Add worker pool for LDAP group lookup * changelog * Add lock * derefAliases disappeared
This PR aims to make LDAP group lookup more performant by adding a worker pool for group searches. Specifically this is helpful when
use_token_groups=true
and we need to look up every group individually in LDAP associated with the user.In my testing where a LDAP user is a member of 300 LDAP groups and has 300 policies mapped to those groups I see significant performance increase by using a worker pool:
Before:
After: