Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: [VAULT-18178] Fix filter/search bug for pki role #22810

Merged
merged 5 commits into from
Sep 12, 2023
Merged

UI: [VAULT-18178] Fix filter/search bug for pki role #22810

merged 5 commits into from
Sep 12, 2023

Conversation

kiannaquach
Copy link
Contributor

Description
Before bug fix: Screenshot 2023-09-06 at 9 47 25 AM

After: Fixes pki bug for filtering roles.

@kiannaquach kiannaquach added ui bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed labels Sep 6, 2023
@kiannaquach kiannaquach added this to the 1.13.7 milestone Sep 6, 2023
@kiannaquach kiannaquach marked this pull request as ready for review September 7, 2023 17:09
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Build Results:
All builds succeeded! ✅

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

CI Results:
Failures:

Test Type Package Test Logs
plugins/database/mssql TestUpdateUser_password view test results
plugins/database/mssql TestUpdateUser_password/missing_password view test results

@anwittin anwittin modified the milestones: 1.13.7, 1.13.8 Sep 11, 2023
hashishaw
hashishaw approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kiannaquach kiannaquach merged commit 2e332ec into release/1.13.x Sep 12, 2023
95 checks passed
@kiannaquach kiannaquach deleted the ui/VAULT-18178/pki-role-search-bug branch September 12, 2023 15:48
This was referenced Sep 15, 2023
Closed
Closed
Merged
This was referenced Sep 15, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.13.8
Development

Successfully merging this pull request may close these issues.
3 participants
@kiannaquach @hashishaw @anwittin