-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to inspect vault snapshots #23457
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Build Results: |
CI Results: |
In your example above I see there are flags available but the helper description makes no mention of them:
|
thank you!! I fixed this :) |
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
return snapshotInfo, metadata, nil | ||
} | ||
|
||
const ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These consts can go away now right?
Hi @elliesterner, @jasonodonnell, @ncabatoff It seems that backports of this PR (among some others) brought BUSL license to MPL branches 1.13.x and 1.14.x. Has there been any discussion how to solve the license conflict? |
@@ -0,0 +1,3 @@ | |||
```release-note:feature | |||
cli/snapshot: Add CLI tool to inspect Vault snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elliesterner next time please use the correct new feature formatting for new features in the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add some more clarification - this should use the "Feature Name" we'd use in the release notes, and should try to communicate to the user why they would want to learn more about this brand new feature we're introducing in Vault 1.16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elliesterner I see the PR, thanks! I think the correction didn't get merged to the 1.16 release branch, so on the 1.16 release branch it still has the original text. It's still being generated with this text. I added the backport label to the PR you linked. Could you please help ensure the 1.16 backport PR merges?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, yes will fix. Thank you!
Pulled logic extensively from consul snapshot inspector.
Note: we are only verifying the
unsealed
sha sum, and not the sealed sum.Example: