Backport of MongoDB database secret engine - rotate-root - Only default to admin if DB blank into release/1.11.x #23488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/mongodb-rotateroot-allow-non-admin-db/terribly-rested-skunk
branch
from
c2d25f4 to
b0c5a44
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Closing. Do not need to backport to an unsupported Vault version |
fairclothjm
deleted the
backport/mongodb-rotateroot-allow-non-admin-db/terribly-rested-skunk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23240 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
Currently the MongoDB plugin does not allow for
rotate-rootactions unless the user exists already in theadmindatabase.While fine for some use-cases, many environments do not allow true root-level access to MongoDB and separate admins must administer their own databases within Mongo (similar to Vault's namespaces), and it is not unreasonable to expect that teams administering Vault will not be MongoDB admins and therefore not have "full" root access to their target databases.
Overview of commits