api/plugins: add tls-server-name arg for plugin registration #23549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
ncabatoff
approved these changes
Oct 6, 2023
|
Build Results: |
|
CI Results: |
fairclothjm
reviewed
Oct 6, 2023
| @@ -62,6 +63,7 @@ func (f *PluginAPIClientMeta) FlagSet() *flag.FlagSet { | |||
| fs.StringVar(&f.flagCAPath, "ca-path", "", "") | |||
| fs.StringVar(&f.flagClientCert, "client-cert", "", "") | |||
| fs.StringVar(&f.flagClientKey, "client-key", "", "") | |||
| fs.StringVar(&f.flagServerName, "tls-server-name", "", "") | |||
There was a problem hiding this comment.
Should we update any documentation for this?
There was a problem hiding this comment.
I had trouble finding any existing documentation that called these out. Do you happen to know if any exist?
There was a problem hiding this comment.
I didn't find anything either
This was referenced Oct 20, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Vault is running in an ephemeral environment where nodes are often replaced and are randomly assigned IP addresses, it can be difficult to have IP SANs in server certs. By adding a TLS server name configurable we allow operators to register a plugin and specify the acceptable SAN for TLS verification.