Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copy button in collapsed sidebar nav in CopyButton component #23564

Merged

Conversation

Monkeychip
Copy link
Contributor

This is more or less a manual backport but with changes because we don't have the HDS copy button in 1.15. See original PR #23331.

@Monkeychip Monkeychip added this to the 1.14.5 milestone Oct 8, 2023
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it seems to work! Is there a reason you didn't include the changelog on the backport?

@Monkeychip
Copy link
Contributor Author

Tested locally and it seems to work! Is there a reason you didn't include the changelog on the backport?

The original PR had a changelog. But because we didn't have the hds copy button in 1.14 and 1.15, this not a direct backport and so it didn't carry the changelog. Thinking about it now, I should add a changelog to this and the previous backport. For some reason I thought because it was in 1.16 we should be fine (Friday brain decision).

@Monkeychip Monkeychip merged commit 7c367e0 into release/1.14.x Oct 9, 2023
@Monkeychip Monkeychip deleted the ui/fix-copy-root-pre-hds-copy-button-1.14 branch October 9, 2023 17:39
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants