UI Secrets Sync: Destinations adapter add LIST #23716

hellobontempo · 2023-10-17T23:59:30Z

This PR conditionally renders the CTA landing page for secrets sync and builds out the adapter to prep for using lazyPaginatedQuery in the destinations list view

…destination-models

…ew-route-cta

github-actions · 2023-10-18T00:17:06Z

Build Results:
All builds succeeded! ✅

…list-destinations

docs

zofskeez

👏

zofskeez · 2023-10-19T02:02:11Z

ui/app/serializers/sync/destination.js

+  normalizeResponse(store, primaryModelClass, payload, id, requestType) {
+    let transformedPayload = payload;

-  normalizeItems(payload) {
-    if (payload.data?.connection_details) {
-      const data = { ...payload.data, ...payload.data.connection_details };
-      delete data.connection_details;
-      return data;
+    if (requestType === 'findRecord') {
+      transformedPayload = this._normalizeFindRecord(payload);
    }
-    return super.normalizeItems(...arguments);
+    return super.normalizeResponse(store, primaryModelClass, transformedPayload, id, requestType);
+  }


I would love to figure out how to still extend the ApplicationSerializer while being able to use normalizeFindRecordResponse rather than conditionally targeting the requestType but this does the trick.

Yeah...I couldn't find a way around this. I tried a few things like just interrupt normalizeItems and return payload but I got a Maximum call stack exceeded error 🙃

zofskeez · 2023-10-19T02:02:33Z

ui/docs/client-pagination.md

@@ -43,7 +43,7 @@ The `size` param defaults to the default page size set in [the app config](../co

 ### Serializing

-In order to interrupt the regular serialization when using `lazyPaginatedData`, define `extractLazyPaginatedData` on the modelType's serializer. This will be called with the raw response before being cached on the store.
+In order to interrupt the regular serialization when using `lazyPaginatedData`, define `extractLazyPaginatedData` on the modelType's serializer. This will be called with the raw response before being cached on the store. `extractLazyPaginatedData` should return an array of objects.


zofskeez · 2023-10-19T02:05:08Z

ui/lib/sync/addon/routes/secrets/destinations.ts

+        pageFilter: params.pageFilter,
+        responsePath: 'data.keys',
+      },
+      { adapterOptions: { showPartialError: true } }


This was something I added specifically for the ldap roles adapter since multiple endpoints needed to be hit so unless we need to do something similar this can be removed.

zofskeez · 2023-10-19T02:08:23Z

ui/mirage/handlers/sync.js

@@ -33,6 +34,7 @@ export default function (server) {
    if (record) {
      delete record.type;
      delete record.name;
+      delete record.id;


* Ember Engine Setup for Secrets Sync (#23653) * ember engine setup for secrets sync * Update ui/lib/sync/addon/routes.js Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> --------- Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> * Sync Mirage Setup (#23683) * adds mirage setup for sync endpoints * updates secret_name default in sync-association mirage factory * UI Secrets Sync: Ember data sync destinations (#23674) * add models * adapters * base model adapter * update test response * add sync destinations helper * finish renaming base destination model/adapter * add comment * add serializer * use normalizeItems instead * destination serializer test * add destination find method; * add conditional operand * UI Secrets Sync: Overview landing page (#23696) * add models * adapters * base model adapter * update test response * add sync destinations helper * finish renaming base destination model/adapter * add comment * add serializer * doc-link helper * add version service * landing and overview component * overview page * add tests * UI Secrets Sync: Destinations adapter add LIST (#23716) * add models * adapters * base model adapter * update test response * add sync destinations helper * finish renaming base destination model/adapter * add comment * add serializer * doc-link helper * add version service * landing and overview component * overview page * build out serializer and adapters * update mirage * fix merge conflicts * one more conflict! * pull transformQueryResponse to separate method in adapter * move data transforming all to serializer and tests * add note to paginationd ocs docs * conditionally render CTA * add lazyPaginatedQuery method to destinations route * remove partial error * Secrets Sync: Destinations create - select type (#23792) * add category to destinations * build select type page * refactor prompt config situation * routing for destinations * update select-type routing * make card width fixed * revert CTA routing change, keep shouldRenderOverview * add header for gif demo to form * cleanup scope * more scope cleanup * add test * add type selector * rename components * rename again * remove async * fix tests * fix select type rename in test * delete renamed test * fix import of general selectors * rename using component syntax * UI Secrets Sync: Create destination form and route (#23806) * add model attribute metadata * add form and save url, remove name and type from serializer * move checkbox list to form field helper * add styling to alert inline * use newly made class * fix cancel action and cleanup form * change quotes * remove checkbox action from form component * add tests * address feedback * add API error test * use create record method instead * adapter test for create record * return from find method if type is undefined * cleanup test selectors * secrets sync: refactor sync destinations helper (#23839) * refactor getter in base destination model * add getters back to model * Secrets sync UI: Destination details page (#23842) * change labels to match params * add maskedParams to base model * add details route * add details view; * update mirage * fix secrets sync link; * delete parent destination route * add copyright header * add secrets route * move sync route outside of secrets/ route * upate mirage * export to-label * finish tests * make ternary * rename header tabs * fix selector in test * Secrets Sync UI: Cleanup headers + tabs (#23873) * remove destination header component, add headers/tabs to all routes * fix header padding * move tabs + toolbar back into component... * add copyright header * add delete modal * lol revert again * add extra line after copyright header * Secrets Sync Destinations List View (#23949) * adds route and page component for sync destinations list view * filters by type first for sync destinations * adds test for store.filterData method * Update ui/app/services/store.js Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com> * updates nav link label for secrets sync * moves sync destinations types out of app-types * moves loading-dropdown-option component to core addon and adds to destination list item menu * change true assertion to deepEqual in sync destinations test * adds copyright header to sync-destinations type file * clear store dataset on sync destination create --------- Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com> * Sync Destinations Capabilities (#23953) * adds route and page component for sync destinations list view * filters by type first for sync destinations * adds test for store.filterData method * adds capabilities checks for sync destinations * removes canList from sync destinations capabilities * updates sync header tests * Update ui/tests/integration/components/sync/sync-header-test.js Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> * updates sync destination response serialization * updates sync destination serializer test * updates sync destinations page test assertions * fixes mirage sync destinations payload issue * removes commented out method in sync destination adapter * fixes inconsistencies with url generation for sync destinations delete * fixes sync destinations page test --------- Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> * Sync Associations Ember Data Setup (#24132) * adds model, adapter and serializer for sync associations * updates sync association adapter save methods to use adapterOptions to determine action * Sync Destination Secrets Route and Page Component (#24155) * renames sync destination header component and adds tests * adds destination secrets route and page component * adds setup-models helper for sync testing * moves destination details test into subdir * adds destination secrets page component tests * adds controller for destination secrets route * fixes pagination route on destination secrets view * fixes sync association updated_at assertion based on timezone * updates kv secret details external route name * updates usage of old spacing style variable after merge * use confirm action instead of contextual confirm (old) component (#24189) * UI Secrets Sync: Adds secret status to kv v2 details page (#24208) * woops! missed this styling for confirm action swap * update link to go to destination secrets * change edit to view secret from destination secrets list * add synDestination to external routes for kv engine * add sync status badge component * export from addon * splaattributes * poll sync status for kv secret details and render * move from controller to component * update name to new destinationName key * reorder list view items * add refresh button * add mirage data * change to loading static * update icons to be sync specific * change name * move button and change fetch to concurrency task * add tests to kv details * add color assertion * add copyright header * small test tweaks * Update ui/tests/integration/components/sync-status-badge-test.js * fixes test --------- Co-authored-by: Jordan Reimer <zofskeez@gmail.com> * Sync Secrets to Destination (#24247) * fixes issue with filter-input debounce and updates to spread attributes for input rather than use args * adds destination sync page component * removes unused var in sync component * adds test for manual mount path input in sync view * updates mount filtering in destinations sync page to target kv v2 * Secrets Sync Landing Page Images (#24277) * updates sync landing page to add marketing images * removes top margin from sync landing-cta * adds aria-describedby to sync landing images * UI Secrets Sync: Serialize trailing slash from destination type (#24294) * remove trailing slash from type in destination LIST response * update keys in mirage and tests * Sync Overview (#24340) * updates landing-cta image to png with matching height * adds ts definitons for sync adapters * updates sync adapters and serializers to add methods for fetching overview data * adds sync associations list handler to mirage and seeds more associations in scenario * adds table and totals cards to sync overview page * adds sync overview page component tests * fixes tests * changes lastSync key to lastUpdated for sync fetchByDestinations response * adds emdash as placeholder for lastUpdated null value in secrets by destination table * updates to handle 0 associations state for destination in overview table * Secrets Sync UI: Add loading and error substates (#24353) * add error substate * add loading substates * delete loading from secrets route * Remove is-version Helper (#24388) * removes is-version helper and injects service into components * updates sync tests using version service to new API * adds comment back for tracked property in secret detials page component * updates sync tests to use common selectors (#24397) * update capitalization to consistently be titlecase, fix breadcrumb selector * clears sync associations from store on destination sync page component destroy (#24450) * KV Suggestion Input (#24447) * updates filter-input component to conditionally show search icon * adds kv-suggestion-input component to core addon * updates destination sync page component to use KvSuggestionInput component * fixes issue in kv-suggestion-input where a partial search term was not replaced with the selected suggestion value * updates kv-suggestion-input to retain focus on suggestion click * fixes test * updates kv-suggestion-input to conditionally render label component * adds comments to kv-suggestion-input regarding trigger * moves alert banner in sync page below button set * moves inputId from getter to class property on kv-suggestion-input * Secrets Sync UI: Editing a destination (#24413) * add form field groups to sync models * update create-and-edit form to use confirmLeave and enableInput component * enable input component * add more stars * update css comments * Update ui/app/styles/helper-classes/flexbox-and-grid.scss * make attrOptions optional * remove decorator * add env variables to subtexr * add subtext to textfile * fix overviwe transition bug * remove breadcrumbs to getter * WIP adapter update * update mirage response * add update method with PATCH * add patch to application adapter * fix typo * finish tests * remove validations because could use environment variables * use getter and setter in model * move update record business to serializer * rest of logic in serializer; gp ; gp * add model validation warnings * cleanup getters * pull create/update logic into method for mirage * add test for validation warning * update KV copy * Sync Success Banner (#24491) * adds success banner to destination sync page * move submit disabled logic to getter in destination sync page * adds id and for attributes to kv mount input in sync page * hides sync success banner on submit * use Sync secrets everywhere (remove new) (#24494) * use Sync secrets everywhere (remove new) * revert test name change * Sync Destinations List Filter Bug (#24496) * fixes issues filtering destinations list * adds test * fixes Sync now action text alignment in destination secrets list * UI Secrets sync: Add purge query param to delete endpoint (#24497) * adds updated_at to mirage set association handler * adds changelog entry * add enterprise in parenthesis for changelog * addres a11y feedback --------- Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> Co-authored-by: clairebontempo@gmail.com <clairebontempo@gmail.com> Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>

hellobontempo added 16 commits October 16, 2023 09:36

add models

a07e039

adapters

e2cd3b2

base model adapter

17959ec

update test response

96c8a05

Merge branch 'ui/VAULT-17968/secrets-sync' into ui/VAULT-21049/ember-…

00b3f2b

…destination-models

add sync destinations helper

76ac9ba

finish renaming base destination model/adapter

2772cd6

add comment

3fd98f0

add serializer

3e22e15

doc-link helper

705f420

add version service

377807c

landing and overview component

e238920

Merge branch 'ui/VAULT-17968/secrets-sync' into ui/VAULT-21036/overvi…

6b71489

…ew-route-cta

overview page

2a45393

build out serializer and adapters

1fc759b

update mirage

59294ce

hellobontempo added ui pr/no-changelog labels Oct 17, 2023

hellobontempo added this to the 1.16.0-rc1 milestone Oct 17, 2023

github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 17, 2023

hellobontempo changed the base branch from main to ui/VAULT-17968/secrets-sync October 17, 2023 23:59

hellobontempo added 8 commits October 17, 2023 18:08

Merge branch 'ui/VAULT-17968/secrets-sync' into ui/VAULT-21208/query-…

26e5890

…list-destinations

fix merge conflicts

f31c2a1

one more conflict!

4784436

pull transformQueryResponse to separate method in adapter

59a0a86

move data transforming all to serializer and tests

8d186c1

add note to paginationd ocs

0799124

docs

conditionally render CTA

9d380de

add lazyPaginatedQuery method to destinations route

264554e

zofskeez approved these changes Oct 19, 2023

View reviewed changes

remove partial error

c90f169

hellobontempo merged commit 866b61f into ui/VAULT-17968/secrets-sync Oct 19, 2023

hellobontempo deleted the ui/VAULT-21208/query-list-destinations branch October 19, 2023 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI Secrets Sync: Destinations adapter add LIST #23716

UI Secrets Sync: Destinations adapter add LIST #23716

hellobontempo commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 18, 2023

zofskeez left a comment

zofskeez Oct 19, 2023

hellobontempo Oct 19, 2023

zofskeez Oct 19, 2023

zofskeez Oct 19, 2023

zofskeez Oct 19, 2023

UI Secrets Sync: Destinations adapter add LIST #23716

UI Secrets Sync: Destinations adapter add LIST #23716

Conversation

hellobontempo commented Oct 17, 2023 • edited Loading

github-actions bot commented Oct 18, 2023

zofskeez left a comment

Choose a reason for hiding this comment

zofskeez Oct 19, 2023

Choose a reason for hiding this comment

hellobontempo Oct 19, 2023

Choose a reason for hiding this comment

zofskeez Oct 19, 2023

Choose a reason for hiding this comment

zofskeez Oct 19, 2023

Choose a reason for hiding this comment

zofskeez Oct 19, 2023

Choose a reason for hiding this comment

hellobontempo commented Oct 17, 2023 •

edited

Loading