Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add banner for when resultant-acl check fails into release/1.15.x #23728

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #23503 to be assessed for backporting due to the inclusion of the label backport/1.15.x.

The below text is copied from the body of the original PR.


The resultant-acl endpoint is an internal endpoint that is critical for the UI to deliver an interface that shows a given user only the navigation items they have access to. However, access to this endpoint is controlled via policies, so if a GUI user does not have the default policy (which includes read access to this endpoint) the user might see navigation items that they don't actually have access to.

To alleviate confusion we are adding an alert banner when this check fails:
Resultant ACL banner

This check will also fail if the given user doesn't have access to the namespace, so the log in CTA will have them sign in directly to the namespace with a different user.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/ui/VAULT-18684/banner-when-resultant-acl-fails/positively-unified-mink branch from 1b95a22 to 0dc0460 Compare October 18, 2023 21:52
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 18, 2023
@github-actions
Copy link

Build Results:
All builds succeeded! ✅

@schavis schavis added the vault-update Used by SPE team to filter out PRs not related to content label Oct 19, 2023
@hashishaw hashishaw added this to the 1.15.1 milestone Oct 19, 2023
@hashishaw hashishaw merged commit 6f8f82e into release/1.15.x Oct 19, 2023
@hashishaw hashishaw deleted the backport/ui/ui/VAULT-18684/banner-when-resultant-acl-fails/positively-unified-mink branch October 19, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui vault-update Used by SPE team to filter out PRs not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants