-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Allow userpass user to update their own password #23797
Conversation
Build Results: |
@icon={{if this.updatePassword.isRunning "loading"}} | ||
type="submit" | ||
data-test-reset-password-save | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know users navigate here from the dropdown, but would it be helpful to add a Cancel
button that brings you back to the dashboard or auth method details?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add it because I wasn't sure where we would redirect the user back to. There are a few other forms like this that do not have a cancel button, and I figured they could get to wherever they wanted to be with the side nav.
<div class="box is-sideless is-fullwidth is-marginless"> | ||
<Hds::Alert @type="inline" @color="success" data-test-reset-password-success as |A|> | ||
<A.Title>Password set successfully</A.Title> | ||
<A.Button @text="Reset form" @color="secondary" {{on "click" this.reset}} data-test-reset-reset-password /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about reset password forms I've used - I'd expect an alert to render that it was successful above the form. It feels like we don't need to include a Reset form
button + action to conditionally render the form.
But perhaps you had other reasons for doing so! Just a small comment about the UX here
</p.levelLeft> | ||
</PageHeader> | ||
|
||
<EmptyState @title="No password reset access" @message={{@this.model.message}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an extra @
here
<EmptyState @title="No password reset access" @message={{@this.model.message}}> | |
<EmptyState @title="No password reset access" @message={{this.model.message}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! This is long overdue and I'm excited to finally have this functionality in the UI! 🎉 A couple of comments/questions, nothing major - except perhaps the minor template arg typo @this.type..
f6cfdad
to
7536f1b
Compare
Allows a userpass user to reset their own password, using the update password API.
New page, and link in user dropdown:
Page and dropdown if user does not have a userpass auth mount:
Error handling on page: