Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update secrets engines sidenav to title-casing #23964

Merged
merged 5 commits into from
Nov 2, 2023
Merged

UI: Update secrets engines sidenav to title-casing #23964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdd5aa3
Update secrets engines sidenav casing
kiannaquach Nov 2, 2023
c314856
Add changelog
kiannaquach Nov 2, 2023
eeda18b
Update all test links
kiannaquach Nov 2, 2023
73a5395
Merge branch 'main' into ui/update-sidenav-secrets-engines
kiannaquach Nov 2, 2023
f15c858
Fix sidebar test
kiannaquach Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/23964.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
ui: Update sidebar Secrets engine to title case.
```
4 changes: 2 additions & 2 deletions ui/app/components/sidebar/nav/cluster.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
<Nav.Link
@route="vault.cluster.secrets"
@current-when="vault.cluster.secrets vault.cluster.settings.mount-secret-backend vault.cluster.settings.configure-secret-backend"
@text="Secrets engines"
data-test-sidebar-nav-link="Secrets engines"
@text="Secrets Engines"
data-test-sidebar-nav-link="Secrets Engines"
/>
{{#if (has-permission "access")}}
<Nav.Link
Expand Down
2 changes: 1 addition & 1 deletion ui/tests/acceptance/secrets/backend/database/secret-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ module('Acceptance | secrets/database/*', function (hooks) {
await authPage.logout();
// Check with restricted permissions
await authPage.login(token);
await click('[data-test-sidebar-nav-link="Secrets engines"]');
await click('[data-test-sidebar-nav-link="Secrets Engines"]');
assert.dom(`[data-test-secrets-backend-link="${backend}"]`).exists('Shows backend on secret list page');
await navToConnection(backend, connection);
assert.strictEqual(
Expand Down
2 changes: 1 addition & 1 deletion ui/tests/acceptance/secrets/backend/kv/kv-v2-workflow-edge-cases-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ module('Acceptance | Enterprise | kv-v2 workflow | edge cases', function (hooks)
setupApplicationTest(hooks);

const navToEngine = async (backend) => {
await click('[data-test-sidebar-nav-link="Secrets engines"]');
await click('[data-test-sidebar-nav-link="Secrets Engines"]');
return await click(PAGE.backends.link(backend));
};

Expand Down
2 changes: 1 addition & 1 deletion ui/tests/acceptance/sidebar-nav-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module('Acceptance | sidebar navigation', function (hooks) {
const links = [
{ label: 'Raft Storage', route: '/vault/storage/raft' },
{ label: 'Seal Vault', route: '/vault/settings/seal' },
{ label: 'Secrets engines', route: '/vault/secrets' },
{ label: 'Secrets Engines', route: '/vault/secrets' },
{ label: 'Dashboard', route: '/vault/dashboard' },
];

Expand Down
2 changes: 1 addition & 1 deletion ui/tests/integration/components/sidebar/nav/cluster-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ module('Integration | Component | sidebar-nav-cluster', function (hooks) {
test('it should render nav links', async function (assert) {
const links = [
'Dashboard',
'Secrets engines',
'Secrets Engines',
'Access',
'Policies',
'Tools',
Expand Down
2 changes: 1 addition & 1 deletion ui/tests/pages/settings/mount-secret-backend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default create({
maxTTLUnit: fillable('[data-test-ttl-unit="Max Lease TTL"] [data-test-select="ttl-unit"]'),
enableDefaultTtl: clickable('[data-test-toggle-input="Default Lease TTL"]'),
enableEngine: clickable('[data-test-enable-engine]'),
secretList: clickable('[data-test-sidebar-nav-link="Secrets engines"]'),
secretList: clickable('[data-test-sidebar-nav-link="Secrets Engines"]'),
defaultTTLVal: fillable('input[data-test-ttl-value="Default Lease TTL"]'),
defaultTTLUnit: fillable('[data-test-ttl-unit="Default Lease TTL"] [data-test-select="ttl-unit"]'),
enable: async function (type, path) {
Expand Down