Backport of VAULT-21435 Use seal wrappers rather than config to determine autoSeal barrier type. into release/1.15.x #24166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/victorr/vault-22031-fix-autoseal-barrier-type/currently-noted-buffalo
branch
from
387f785 to
afa2bb3
Compare
|
|
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
…pe. (#24165) * Use seal wrappers rather than config to determine autoSeal barrier type. A seal's Access object contains all seal configuration, which in the case of seal migration includes the "unwrap seal" as well as the barrier seal. Thus, to determine whether an autoSeal is of a specific type such as 'Transit' or whether it is a 'Multiseal', use the wrappers of the seal's Access. * Fix seal type reported by /sys/seal-status. Fix an error that resulted in the wrong seal type being reported while Vault is in seal migration mode.
victorr
force-pushed
the
backport/victorr/vault-22031-fix-autoseal-barrier-type/currently-noted-buffalo
branch
from
a1a3c7b to
4c726a7
Compare
|
Cherry-pick succeeded without errors once a previous fix was back ported: #24170. |
victorr
approved these changes
Nov 16, 2023
|
Build Results: |
victorr
deleted the
backport/victorr/vault-22031-fix-autoseal-barrier-type/currently-noted-buffalo
branch
victorr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #24165 to be assessed for backporting due to the inclusion of the label backport/1.15.x.
The below text is copied from the body of the original PR.
A seal's Access object contains all seal configuration, which in the case of seal migration includes the "unwrap seal" as well as the barrier seal. Thus, to determine whether an autoSeal is of a specific type such as 'Transit' or whether it is a 'Multiseal', use the wrappers of the seal's Access.
In addition: Fix an error that resulted in the wrong seal type being reported while Vault is in seal migration mode.
Overview of commits