UI: HDS adoption replace footer element #24191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
alex-ju
commented
Nov 20, 2023
| </span> | ||
|
|
||
| <Hds::AppFooter as |AF|> | ||
| <AF.Link @href={{changelog-url-for this.auth.activeCluster.leaderNode.version}}> |
There was a problem hiding this comment.
note: I checked the ExternalLink code and AF.Link generates the same markup (target="_blank" rel="noopener noreferrer")
alex-ju
commented
Nov 20, 2023
ui/app/templates/vault.hbs
Outdated
| </DocLink> | ||
| </span> | ||
| </footer> | ||
| <AF.Link @href="https://developer.hashicorp.com/vault"> |
There was a problem hiding this comment.
note: can't use DocLink anymore so had to hardcode this link it for now
There was a problem hiding this comment.
we have a template helper you can use:
here's an example of where else it's implemented
alex-ju
force-pushed
the
ui/hds-footer
branch
from
dfdd71d
to
e77e725
Compare
|
Build Results: |
hellobontempo
approved these changes
Nov 20, 2023
alex-ju
force-pushed
the
ui/hds-footer
branch
from
d6dce31
to
a9e0a80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
<footer>with<Hds::AppFooter>component in main application template.Notable changes: