Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Handle expired OCSP responses from server into release/1.13.x #24197

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Backport of Handle expired OCSP responses from server into release/1.13.x #24197

merged 1 commit into from
Nov 20, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #24193 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.

  • If a server replies with what we considered an expired OCSP response, NextUpdate is now or in the past, and it was our only response we would panic due to missing error handling logic.
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/vault-22019-certauth-ocsp-panic/mildly-splendid-coral branch from 51d2c96 to 93c1868 Compare November 20, 2023 15:51
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/stevendpclark/vault-22019-certauth-ocsp-panic/mildly-splendid-coral branch from 4af9178 to 4aae440 Compare November 20, 2023 15:51
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 20, 2023
@stevendpclark stevendpclark self-assigned this Nov 20, 2023
@stevendpclark stevendpclark added this to the 1.13.11 milestone Nov 20, 2023
@stevendpclark stevendpclark added backport bug Used to indicate a potential bug auth/cert Authentication - certificates labels Nov 20, 2023
@stevendpclark stevendpclark enabled auto-merge (squash) November 20, 2023 15:55
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@stevendpclark stevendpclark merged commit d20526b into release/1.13.x Nov 20, 2023
@stevendpclark stevendpclark deleted the backport/stevendpclark/vault-22019-certauth-ocsp-panic/mildly-splendid-coral branch November 20, 2023 16:09
@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevendpclark stevendpclark stevendpclark approved these changes

Assignees

@stevendpclark stevendpclark

Labels
auth/cert Authentication - certificates backport bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.13.11
Development

Successfully merging this pull request may close these issues.
2 participants
@hc-github-team-secure-vault-core @stevendpclark