Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: Prevent replication disable action from sending data payload into release/1.14.x #24296

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #24292 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

The below text is copied from the body of the original PR.


Previously we were incorrectly sending a payload on the replication/disable endpoint, which returned a warning. This PR fixes the disable callback so that no payload is sent.

Before:
Warning shown after disable


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/replication-disable-payload/thoroughly-trusted-dog branch 2 times, most recently from 46bcae6 to 7851f7c Compare November 29, 2023 22:41
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Nov 29, 2023
@hashishaw hashishaw added this to the 1.14.8 milestone Nov 29, 2023
@hashishaw hashishaw enabled auto-merge (squash) November 29, 2023 22:43
@hashishaw hashishaw disabled auto-merge November 29, 2023 22:44
@hashishaw hashishaw enabled auto-merge (squash) November 29, 2023 22:51
@hashishaw hashishaw merged commit 28eff53 into release/1.14.x Nov 29, 2023
Copy link

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw deleted the backport/ui/replication-disable-payload/thoroughly-trusted-dog branch November 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants