Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PATCH to CORS allowed request methods #24373

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Add PATCH to CORS allowed request methods #24373

merged 2 commits into from
Dec 7, 2023

Conversation

miagilepner
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Dec 5, 2023
@miagilepner miagilepner added this to the 1.16.0-rc1 milestone Dec 5, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

CI Results:
Failures:

Test Type Package Test Logs
race vault TestCore_HandleRequest_CreateToken_Lease view test results

@miagilepner miagilepner marked this pull request as ready for review December 5, 2023 18:02
@miagilepner miagilepner requested a review from a team December 5, 2023 18:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Build Results:
All builds succeeded! ✅

hghaf099
hghaf099 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@hghaf099 hghaf099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raskchanky
raskchanky approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@raskchanky raskchanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miagilepner miagilepner merged commit 959d548 into main Dec 7, 2023
160 of 162 checks passed
@miagilepner miagilepner deleted the miagilepner/patch-cors branch December 7, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hghaf099 hghaf099 hghaf099 approved these changes

@raskchanky raskchanky raskchanky approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@miagilepner @raskchanky @hghaf099