-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reloading database plugins across multiple mounts #24512
Support reloading database plugins across multiple mounts #24512
Conversation
Build Results: |
CI Results: |
aaaf517
to
87e0336
Compare
87e0336
to
0a70e8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Note: With the latest commit, I also removed the |
This builds on #24472 to support reloading database plugins across multiple mounts. The next stage will be to implement a new root-namespace-only endpoint that allows reloading plugins across multiple namespaces, which will leverage the same function but with some updates. At that point, admins in the root namespace will have everything they need to ensure they can reload all instances of a plugin they've just updated in the plugin catalog without having to enumerate all mounts and namespaces.
This also adds a warning to the response if a reload request ever succeeds but without actually reloading a plugin, for example because the plugin wasn't in use, or if the plugin doesn't even exist in the catalog. We report number of reloads instead of explicitly telling users about whether or not the plugin exists to avoid (admittedly fairly low stakes) enumeration attacks on the contents of the catalog.