-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: fix PKI issuer capabilities #24686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jan 5, 2024
Monkeychip
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for tackling. Curious if this was caught in the ember-data upgrade?
@Monkeychip it was actually the ember-exam PR! |
meirish
reviewed
Jan 5, 2024
Build Results: |
This was referenced Jan 5, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Jan 5, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Jan 5, 2024
Monkeychip
pushed a commit
that referenced
this pull request
Jan 7, 2024
hashishaw
added a commit
that referenced
this pull request
Jan 8, 2024
hashishaw
added a commit
that referenced
this pull request
Jan 8, 2024
hashishaw
added a commit
that referenced
this pull request
Jan 8, 2024
hashishaw
added a commit
that referenced
this pull request
Jan 8, 2024
hashishaw
added a commit
that referenced
this pull request
Jan 9, 2024
hashishaw
added a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Used to indicate a potential bug
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where capabilities on PKI issuers were incorrectly calculated. The workflow tests did not catch this because we weren't clearing the store of
capabilities
entries after setup, which means the UI was using the old capabilities in memory from the root setup.