Prep for Ember data: misc #2 #24791
Merged
Prep for Ember data: misc #2 #24791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of string selectors
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
Monkeychip
commented
Jan 11, 2024
hashishaw
reviewed
Jan 11, 2024
| @@ -308,26 +306,27 @@ module('Acceptance | landing page dashboard', function (hooks) { | |||
| }; | |||
|
|
|||
| test('shows the correct actions and links associated with database', async function (assert) { | |||
| await mountSecrets.enable('database', 'database'); | |||
| await newConnection('database'); | |||
| const databaseBackend = `db-database`; | |||
There was a problem hiding this comment.
we should probably use a uuid here
There was a problem hiding this comment.
Good call! I'll amend.
hashishaw
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a new WIP ember upgrade branch that has Ember exam merged in. While creating that branch, I was able to confirm several test changes that are still needed but are not upgrade dependent. Regardless of the ember data upgrade these changes are good housekeeping.