-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Census manual reporting : Always enable manual reporting CE changes #24847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Results: |
CI Results: |
hghaf099
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This was referenced Jan 12, 2024
hghaf099
pushed a commit
that referenced
this pull request
Jan 30, 2024
hghaf099
pushed a commit
that referenced
this pull request
Jan 31, 2024
hghaf099
added a commit
that referenced
this pull request
Feb 1, 2024
* adding oss changes from ent (#24847) * manual licese reporting persist snapshots CE (#25021) * Manual census snapshot cleanup changes CE (#25061) * snapshot cleanup oss * CE changes for the API PR * godoc for test --------- Co-authored-by: hamid ghaf <hamid@hashicorp.com> * census manual reporting API sys help (#25097) * manual reporting cli oss changes (#25109) * go mod tidy * revert to mitchell/cli * revert some dependency changes --------- Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com>
hghaf099
added a commit
that referenced
this pull request
Feb 2, 2024
* adding oss changes from ent (#24847) * manual licese reporting persist snapshots CE (#25021) * Manual census snapshot cleanup changes CE (#25061) * snapshot cleanup oss * CE changes for the API PR * godoc for test --------- Co-authored-by: hamid ghaf <hamid@hashicorp.com> * census manual reporting API sys help (#25097) * manual reporting cli oss changes (#25109) * adding hashicorp cli * revert to mitchell cli --------- Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
pr/no-changelog
pr/no-milestone
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://hashicorp.atlassian.net/browse/VAULT-22877
Ent PR: https://github.com/hashicorp/vault-enterprise/pull/5168
Description
A customer may choose to manually export the data using the CLI command regardless if they have chosen to opt in or out of automated reporting. This is especially true if a customer has chosen to opt out of automated reporting especially because they have to use the manual method. Manual reporting can also be used to export data where automated reporting fails. Therefore, as part of this effort, manual reporting will always be enabled from now on.