Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Census manual reporting : Always enable manual reporting CE changes #24847

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

akshya96
Copy link
Contributor

@akshya96 akshya96 commented Jan 12, 2024

JIRA: https://hashicorp.atlassian.net/browse/VAULT-22877
Ent PR: https://github.com/hashicorp/vault-enterprise/pull/5168
Description
A customer may choose to manually export the data using the CLI command regardless if they have chosen to opt in or out of automated reporting. This is especially true if a customer has chosen to opt out of automated reporting especially because they have to use the manual method. Manual reporting can also be used to export data where automated reporting fails. Therefore, as part of this effort, manual reporting will always be enabled from now on.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 12, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link
Contributor

@hghaf099 hghaf099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akshya96 akshya96 merged commit bc9be55 into main Jan 12, 2024
117 checks passed
@akshya96 akshya96 deleted the vault-22877-oss branch January 12, 2024 23:17
hghaf099 pushed a commit that referenced this pull request Jan 30, 2024
hghaf099 pushed a commit that referenced this pull request Jan 31, 2024
hghaf099 added a commit that referenced this pull request Feb 1, 2024
* adding oss changes from ent (#24847)

* manual licese reporting persist snapshots CE (#25021)

* Manual census snapshot cleanup changes CE (#25061)

* snapshot cleanup oss

* CE changes for the API PR

* godoc for test

---------

Co-authored-by: hamid ghaf <hamid@hashicorp.com>

* census manual reporting API sys help (#25097)

* manual reporting cli oss changes (#25109)

* go mod tidy

* revert to mitchell/cli

* revert some dependency changes

---------

Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com>
hghaf099 added a commit that referenced this pull request Feb 2, 2024
* adding oss changes from ent (#24847)

* manual licese reporting persist snapshots CE (#25021)

* Manual census snapshot cleanup changes CE (#25061)

* snapshot cleanup oss

* CE changes for the API PR

* godoc for test

---------

Co-authored-by: hamid ghaf <hamid@hashicorp.com>

* census manual reporting API sys help (#25097)

* manual reporting cli oss changes (#25109)

* adding hashicorp cli

* revert to mitchell cli

---------

Co-authored-by: akshya96 <87045294+akshya96@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants