Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List plugin runtimes API always includes a list even if empty #24864

Merged
merged 3 commits into from
Jan 16, 2024
Merged

List plugin runtimes API always includes a list even if empty #24864

merged 3 commits into from
Jan 16, 2024

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Jan 15, 2024

The api package expects the "runtimes" key to always be there or it errors, but the API was omitting it when empty.

vault/api/sys_plugins_runtimes.go

Lines 162 to 164 in cd76e4f

if _, ok := secret.Data["runtimes"]; !ok {
return nil, fmt.Errorf("data from server response does not contain runtimes")
}

@tomhjp tomhjp requested review from thyton and a team January 15, 2024 14:59
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@tomhjp tomhjp added this to the 1.16.0-rc1 milestone Jan 16, 2024
@benashz benashz self-requested a review January 16, 2024 14:57
benashz
benashz approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor nit to consider, but otherwise LGTM!

vault/logical_system.go Show resolved Hide resolved
kschoche
kschoche approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomhjp tomhjp enabled auto-merge (squash) January 16, 2024 16:23
@tomhjp tomhjp merged commit f393241 into main Jan 16, 2024
108 checks passed
@tomhjp tomhjp deleted the fix-list-runtimes-response branch January 16, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@kschoche kschoche kschoche approved these changes

@thyton thyton Awaiting requested review from thyton

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0-rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@tomhjp @kschoche @benashz