Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkcs7: fix slice out-of-bounds panic #24891

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

fairclothjm
Copy link
Contributor

No description provided.

@fairclothjm fairclothjm added this to the 1.15.5 milestone Jan 16, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 16, 2024
@fairclothjm
Copy link
Contributor Author

These files were recently moved so I don't think I can use the auto-backport label. I will need to manually fix 1.15.x, 1.14.x and 1.13.x

@fairclothjm fairclothjm requested review from a team and mickael-hc January 16, 2024 18:51
Copy link

github-actions bot commented Jan 16, 2024

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had 1 nit but the changes LGTM!

helper/pkcs7/ber.go Show resolved Hide resolved
@fairclothjm fairclothjm merged commit 3fffae9 into main Jan 17, 2024
110 checks passed
@fairclothjm fairclothjm deleted the VAULT-20399/tob-slice-oob branch January 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants