-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump github.com/hashicorp/go-kms-wrapping/wrappers/azurekeyvault/v2 version to include support for azure workload identities #24954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion to include support for azure workload identities
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jan 19, 2024
elliesterner
requested review from
jasonodonnell,
ltcarbonell,
davidadeleon,
austingebauer and
calvn
January 19, 2024 13:11
Build Results: |
CI Results: |
austingebauer
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was referenced Jan 23, 2024
Thanks a lot @elliesterner! |
elliesterner
added a commit
that referenced
this pull request
Jan 25, 2024
…ersion to include support for azure workload identities (#24954) * bump github.com/hashicorp/go-kms-wrapping/wrappers/azurekeyvault/v2 version to include support for azure workload identities * add changelog * bump azurekeyvault/v2 to 2.0.10 * bump azcore to 1.9.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades github.com/hashicorp/go-kms-wrapping/wrappers/azurekeyvault/v2 which includes support for azure workload identity authentication. It seems like this may have been omitted from the original PR #22994