Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Make resultant-acl banner dismissable #25106

Merged
merged 4 commits into from
Jan 26, 2024
Merged

UI: Make resultant-acl banner dismissable #25106

merged 4 commits into from
Jan 26, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jan 26, 2024 •
edited
Loading

Allows the resultant-acl banner to be dismissed

Screenshot 2024-01-26 at 13 52 27

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.15.x labels Jan 26, 2024
@hashishaw hashishaw added this to the 1.15.5 milestone Jan 26, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 26, 2024
@hashishaw hashishaw enabled auto-merge (squash) January 26, 2024 19:53
Monkeychip
Monkeychip approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming folks don't stick around and click throughout the app if they're in this state, so storing the dismissal in localStorage is unnecessary. Commenting mostly for posterity in case the question comes up later.

@hashishaw hashishaw merged commit dc9d1e2 into main Jan 26, 2024
66 checks passed
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw deleted the ui/dismissable-resultant-acl-banner branch January 26, 2024 20:17
Merged
Monkeychip pushed a commit that referenced this pull request Jan 29, 2024
@hashishaw @Monkeychip
UI: Make resultant-acl banner dismissable (#25106)
0bb487a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.15.5
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @Monkeychip