Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Sync UI: Add granularity to sync destinations into release/1.16.x #25536

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Backport of Sync UI: Add granularity to sync destinations into release/1.16.x #25536

merged 1 commit into from
Feb 21, 2024

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #25500 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.

UI updates adding granularity field to a sync destination.

  • Added granularity field to destination form
  • Added secret key badge to list view
  • Add copy to popup menu so user knows any actions performed on a key will apply to the secret, not the individual key. I updated to use the Hds::Dropdown so that adding copy to the popup menu was cleaner

updates

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-24177/add-granularity-to-sync-destinations/firstly-talented-marmot branch from 76f43ff to e6eaaed Compare February 20, 2024 21:17
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 20, 2024
@zofskeez zofskeez added this to the 1.16.0 milestone Feb 20, 2024
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

hashishaw
hashishaw approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I noticed that we called KV version 2 "KV v2" somewhere but that's likely present on the main PR too

@zofskeez zofskeez merged commit 917e97a into release/1.16.x Feb 21, 2024
23 of 25 checks passed
@zofskeez zofskeez deleted the backport/ui/VAULT-24177/add-granularity-to-sync-destinations/firstly-talented-marmot branch February 21, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

@hellobontempo hellobontempo Awaiting requested review from hellobontempo

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hc-github-team-secure-vault-core @hashishaw @zofskeez @hellobontempo