UI: Ember deprecation - transition methods part 1 #25560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
hashishaw
commented
Feb 22, 2024
| }), | ||
|
|
||
| actions: { | ||
| navAfterSave({ saveType, model }) { |
There was a problem hiding this comment.
This method as a task was causing test failures
hashishaw
changed the title
hashishaw
force-pushed
the
ui/VAULT-23571/deprecation-transition-methods
branch
from
3308b92 to
ed3f374
Compare
global failure: TypeError: While generating link to route "vault.cluster.settings.auth.configure.section": Cannot read properties of undefined (reading 'shouldSupersede')
Global error: Uncaught TransitionAborted: TransitionAborted
|
Build Results: |
Monkeychip
reviewed
Feb 22, 2024
| setupApplicationTest(hooks); | ||
|
|
||
| hooks.beforeEach(async function () { | ||
| await authPage.login(); | ||
| return; | ||
| }); | ||
|
|
||
| skip('it allows create, list, delete of an entity alias', async function (assert) { | ||
| test('it allows create, list, delete of an entity alias', async function (assert) { |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
this.transitionToin routes andthis.transitionToRoutein controllers everywhere except within the replication engine. That one is running into errors and is worth tackling in a separate PR.