Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets Import documentation #25594
Secrets Import documentation #25594
Changes from 5 commits
b0724f2
d793357
eaf2a9e
51c9268
ce6f30c
22c9a1e
194a621
da4323c
34a5f71
302831c
2435ae0
9aa1b51
7af65e8
11c8ae8
f8232dc
9735bc7
38fb9d7
a94fd7c
4e6f242
d14f0e1
2fa7329
908c858
5359662
1285247
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we explain what are these and what are the types & fields available in the HCL schema?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like instead of explaining here, it should just link to the main docs pages explaining the feature. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
#
mean?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't actually know, I copied this flag description from another command doc that has it too. There's a handful of files that have this, for example
website/content/docs/commands/server.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The general documentation typically uses a walkthrough style that guides the user through a full-working example from start to finish. Do you think the same pattern would be useful for Secrets Import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had first copied our usual format based on other docs to base these on, but I started to notice when writing the GCP page that other source pages would be nearly identical. The only section that would be different is explaining the source block with the rest being unchanged. I figure it makes sense to have a small page for each source block, a page for the mappings, and put the destination info on the index page since we are only dealing with Vault as a destination.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Walking folks through a full working example is specific to tutorials. Docs have a more focused purpose. Overviews provide the who/what/where/when/why/how of a feature or function. And how-to guides provide explicit-but-generalized steps for solving specific problems.
If this doc is an overview. Focus on explaining:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here, we might need guidance to create an
alpha
orexperimental
alert.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we've publicly documented alpha or experimental features before. If that's needed here, feel free to create a new partial by using the beta partial as a template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added an experimental that I'll push up soon to be reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we loop in product or marketing here to validate the wording fits with their vision? It feels like a snippet they'd normally provide or would like to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we document the address and token if they are always overridden? There is no reason for a Vault user to define these in their config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe they are always overridden, I think they are only loaded from the client if they are unset in the plan, hence why it's optional. Do you know if I am forgetting something?