helper/metricsutil: Update usage of expfmt #25799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous exposed constants are no longer exposed and we can use expfmt.Format instead. prometheus/common#576
|
|
peteski22
reviewed
Mar 7, 2024
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/common/expfmt" | ||
|
|
There was a problem hiding this comment.
Please could you remove the blank line and reformat the imports? Thanks 😄
"github.com/armon/go-metrics"
"github.com/hashicorp/vault/sdk/logical"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/common/expfmt"
peteski22
approved these changes
Mar 14, 2024
peteski22
added
pr/no-changelog
pr/no-milestone
dependencies
|
Closing as this has been merged in #25947 |
|
Thanks! We're currently busy at our Offsite, so this was definitely quicker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously exposed constants are no longer exposed, and we can use
expfmt.Formatinstead. prometheus/common#576Once Prometheus gets updated, the Vault dependency breaks.