[secrets sync] remove incorrect dom assertion #26131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
andaley
changed the title
|
Build Results: |
|
CI Results: |
hellobontempo
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a test failure caused by an incorrect assertion.
@hellobontempo and I paired on this and we believe the error is occurring because client activity data is generated as the test suite runs other acceptance tests. This correctly caused the
<UsageStats />component not to render (since there was activity data).Next up we should rewrite the test to stub the activity response to return 0 clients. That way we're ensuring that we can consistently predict the Vault cluster's client activity.