Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Update vault-plugin-auth-jwt to v0.20.3 into release/1.14.x #26922

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26890 to be assessed for backporting due to the inclusion of the label backport/1.14.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@thyton
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR was generated by a GitHub Action. Full log: https://github.com/hashicorp/vault/actions/runs/9009980689


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 10, 2024
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

CI Results:
All Go tests succeeded! ✅

@fairclothjm
Copy link
Contributor

@thyton I don't think we can backport v0.20.3 of the auth jwt plugin into Vault v1.14.x. If this fix must go into 1.14, we will need to backport the fix to the plugin's v0.18.x. I have not verified the exact versions though so please double check that. Let me know if you need help!

@schavis schavis added vault-update Used by SPE team to filter out PRs not related to content failed-backport labels May 11, 2024
@thyton
Copy link
Contributor

thyton commented May 14, 2024

@fairclothjm Thank you for pointing this out. I think the version we need v0.16.1 of the auth jwt plugin based on https://github.com/hashicorp/vault/blob/release/1.14.x/go.mod#L131

I'm closing this automated backport PR.

@thyton thyton closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed vault-update Used by SPE team to filter out PRs not related to content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants