Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: remove stored token if cluster needs init into release/1.16.x #26988

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #26985 to be assessed for backporting due to the inclusion of the label backport/1.16.x.

The below text is copied from the body of the original PR.


This PR prevents a rare edge case that makes the UI unusable, which happens when there is a token stored locally but the Vault cluster needs initialization. If this happens, the Vault UI will look like it's loading forever, while the network has a lot of failed API calls:

Example of bug
Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-26930/prevent-ui-stuck-in-loading-state/secretly-assured-chamois branch from 6a591d0 to 3ed579f Compare May 13, 2024 17:07
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 13, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw added this to the 1.16.3 milestone May 13, 2024
@hashishaw hashishaw merged commit ef4f43d into release/1.16.x May 13, 2024
27 of 29 checks passed
@hashishaw hashishaw deleted the backport/ui/VAULT-26930/prevent-ui-stuck-in-loading-state/secretly-assured-chamois branch May 13, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants