New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated default_report_months #27350

Merged

divyaac merged 20 commits into main from VAULT-27635_Deprecate_Default_Report

Jun 6, 2024

Contributor

divyaac commented Jun 4, 2024 •

edited

Loading

Matching ENT PR: https://github.com/hashicorp/vault-enterprise/pull/5929

closes https://github.com/hashicorp/vault-enterprise/pull/5929

divyaac requested a review from a team as a code owner

June 4, 2024 19:25

github-actions bot added the hashicorp-contributed-pr label

vercel bot deployed to Preview

June 4, 2024 19:31

View deployment

mpalmi reviewed

View reviewed changes

Contributor

mpalmi left a comment

Just a couple of things that I think should be addressed before merging.

website/content/docs/upgrading/index.mdx Outdated Show resolved Hide resolved

vault/external_tests/activity/activity_test.go Outdated Show resolved Hide resolved

github-actions bot commented Jun 4, 2024 •

edited

Loading

CI Results:
All Go tests succeeded! ✅

github-actions bot commented Jun 4, 2024 •

edited

Loading

Build Results:
All builds succeeded! ✅

divyaac requested a review from mpalmi

June 4, 2024 20:01


          Deprecated default_report_months through docs and upgrade guides

560107e

divyaac force-pushed the VAULT-27635_Deprecate_Default_Report branch from 1641a74 to 560107e Compare

June 4, 2024 20:05

vercel bot deployed to Preview

June 4, 2024 20:11

View deployment


          Added upgraade doc

82ee53b

vercel bot had a problem deploying to Preview

June 4, 2024 20:14

Failure

mpalmi reviewed

View reviewed changes

Contributor

mpalmi left a comment

Super close, @divyaac! Just a couple more items and then we should be good to merge.

website/content/docs/upgrading/upgrade-to-1.18.x.mdx Outdated Show resolved Hide resolved

website/content/docs/upgrading/upgrade-to-1.18.x.mdx Outdated Show resolved Hide resolved

vault/logical_system_activity.go Outdated Show resolved Hide resolved

website/content/docs/upgrading/index.mdx Outdated Show resolved Hide resolved

website/content/docs/upgrading/upgrade-to-1.18.x.mdx Outdated Show resolved Hide resolved

mpalmi reviewed

View reviewed changes

website/content/api-docs/system/internal-counters.mdx Outdated Show resolved Hide resolved

divyaac requested a review from schavis

June 4, 2024 20:42


          Update website/content/docs/upgrading/upgrade-to-1.18.x.mdx

8aa6738

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

vercel bot had a problem deploying to Preview

June 4, 2024 20:44

Failure

schavis requested changes

View reviewed changes

website/content/api-docs/system/internal-counters.mdx Outdated Show resolved Hide resolved

website/content/api-docs/system/internal-counters.mdx Outdated Show resolved Hide resolved

website/content/docs/upgrading/index.mdx Outdated Show resolved Hide resolved

website/content/docs/upgrading/upgrade-to-1.18.x.mdx Outdated Show resolved Hide resolved

divyaac and others added 3 commits

June 5, 2024 12:14


          Update website/content/api-docs/system/internal-counters.mdx

52b6bf6

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>


          Update website/content/docs/upgrading/upgrade-to-1.18.x.mdx

bdda574

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>


          Update vault/logical_system_activity.go

f931826

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

vercel bot had a problem deploying to Preview

June 5, 2024 19:29

Failure

vercel bot had a problem deploying to Preview

June 5, 2024 20:53

Failure

divyaac force-pushed the VAULT-27635_Deprecate_Default_Report branch from df20a55 to f931826 Compare

June 5, 2024 20:57


          updated code sample

0e39fcf

divyaac requested review from schavis and mpalmi

June 5, 2024 21:09

hashicorp deleted a comment from digital-content-events bot

vercel bot had a problem deploying to Preview

June 5, 2024 21:11

Failure


          Added changelog

a7f0eed

divyaac added this to the 1.18.0-rc milestone

divyaac mentioned this pull request

Set default reporting start time to billing start date #27379

Merged

mpalmi requested changes

View reviewed changes

website/content/docs/upgrading/index.mdx Outdated Show resolved Hide resolved

website/content/docs/upgrading/upgrade-to-1.18.x.mdx Outdated Show resolved Hide resolved

website/content/docs/upgrading/upgrade-to-1.18.x.mdx Outdated

+              endpoint, will result in the following warning from Vault:
+              <CodeBlockConfig hideClipboard>
+              ```shell-session
+              default_report_months is deprecated: defaulting to billing start time

Contributor

mpalmi Jun 6, 2024

It might be more helpful to show an actual request/output, as a user might see it.

Not really a blocker, so if it's a pain I can approve once the other items are addressed.

changelog/27350.txt Outdated Show resolved Hide resolved

divyaac and others added 3 commits

June 6, 2024 09:41


          Update website/content/docs/upgrading/upgrade-to-1.18.x.mdx

2473ddf

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>


          Update changelog/27350.txt

c8c289f

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>


          Update website/content/docs/upgrading/index.mdx

b9eef1d

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>

divyaac requested a review from mpalmi

June 6, 2024 16:42

divyaac added 2 commits

June 6, 2024 09:43


          Update upgrade-to-1.18.x.mdx

7b5e51a


          Update upgrade-to-1.18.x.mdx

1b76519

vercel bot had a problem deploying to Preview

June 6, 2024 16:48

Failure

mpalmi approved these changes

View reviewed changes

Contributor

mpalmi left a comment

Good stuff, @divyaac! Looks like this is ready to merge.

divyaac added 2 commits

June 6, 2024 10:23


          Added docs nav

778273e


          Edited docs nav

0f18000

vercel bot had a problem deploying to Preview

June 6, 2024 17:35

Failure

divyaac and others added 2 commits

June 6, 2024 10:55


          Merge branch 'main' into VAULT-27635_Deprecate_Default_Report

649aa69


          Edited docs

2563db3

vercel bot deployed to Preview

June 6, 2024 18:08

View deployment

divyaac enabled auto-merge (squash)

June 6, 2024 18:27


          Merge branch 'main' into VAULT-27635_Deprecate_Default_Report

d85b690

divyaac disabled auto-merge

June 6, 2024 18:35


          Merge branch 'main' into VAULT-27635_Deprecate_Default_Report

b3a4e08

divyaac enabled auto-merge (squash)

June 6, 2024 21:35


          Merge branch 'main' into VAULT-27635_Deprecate_Default_Report

63be3dd

divyaac commented

View reviewed changes

Contributor Author

divyaac left a comment

Addressed the changes with the resolved commits!

divyaac requested review from schavis and removed request for schavis

June 6, 2024 21:44

schavis approved these changes

View reviewed changes

divyaac merged commit 59320bb into main

84 checks passed

divyaac deleted the VAULT-27635_Deprecate_Default_Report branch

June 6, 2024 21:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr