enos: use the initial version's install dir in upgrade #27496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
rebwill
approved these changes
Jun 13, 2024
|
CI Results:
and 109 - 10 other tests |
|
Build Results: |
ryancragun
force-pushed
the
ryan/fix-upgrade
branch
2 times, most recently
from
2d54150 to
895b5a2
Compare
ryancragun
changed the title
ryancragun
force-pushed
the
ryan/fix-upgrade
branch
3 times, most recently
from
8194272 to
b2cc6a5
Compare
Fix the upgrade scenario by utilizing the correct Vault install location for the initial install and by using different initial upgrade versions. Before we had upgrade versions that were only available for Enterprise which would fail on CE. Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
force-pushed
the
ryan/fix-upgrade
branch
from
b2cc6a5 to
8c9198e
Compare
ryancragun
added a commit
that referenced
this pull request
Jun 17, 2024
Fix the upgrade scenario by utilizing the correct Vault install location for the initial install and by using different initial upgrade versions. Before we had upgrade versions that were only available for Enterprise which would fail on CE. Signed-off-by: Ryan Cragun <me@ryan.ec>
ryancragun
pushed a commit
that referenced
this pull request
Jun 17, 2024
…into release/1.17.x (#27493) * backport of commit 84935e4 * enos: use the correct install during upgrade (#27496) Fix the upgrade scenario by utilizing the correct Vault install location for the initial install and by using different initial upgrade versions. Before we had upgrade versions that were only available for Enterprise which would fail on CE. Signed-off-by: Ryan Cragun <me@ryan.ec>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a race in the
upgradescenario by waiting for the cluster to elect a leader before attempting to get the ip addresses.https://github.com/hashicorp/vault/actions/runs/9503957362/job/26200475179?pr=27493#step:11:55
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.