-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VAULT-28255: Fix namespaced redirects #27660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miagilepner
added
backport/ent/1.15.x+ent
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
labels
Jul 2, 2024
github-actions
bot
added
the
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
label
Jul 2, 2024
CI Results: |
Build Results: |
tvoran
approved these changes
Jul 2, 2024
ccapurso
approved these changes
Jul 2, 2024
6 tasks
miagilepner
added a commit
that referenced
this pull request
Jul 3, 2024
miagilepner
added
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
and removed
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
labels
Jul 3, 2024
miagilepner
added a commit
that referenced
this pull request
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/ent/1.16.x+ent
Changes are backported to 1.16.x+ent
hashicorp-contributed-pr
If the PR is HashiCorp (i.e. not-community) contributed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix redirects when a namespace is included in the namespace header, or for events when it's included in the path.
Fixes #27551.
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+ent
labelsinstead of the old style
backport/x.x.x
labels.the normal
backport/x.x.x
label (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.