Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sys/internal/counters/activity, explain deprecation for current_billing_period #28773

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

lucymhdavies
Copy link
Contributor

@lucymhdavies lucymhdavies commented Oct 25, 2024

Description

per discussion
https://hashicorp.slack.com/archives/CPEPB6WRL/p1729786785076429 the reason this parameter is deprecated is because it's no longer required. make that clear in the docs.

TODO only if you're a HashiCorp employee

I am an employee, but none of the below applies

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

…_billing_period

per discussion
https://hashicorp.slack.com/archives/CPEPB6WRL/p1729786785076429
the reason this parameter is deprecated is because it's no longer required. make that clear in the docs.
@lucymhdavies lucymhdavies requested a review from a team as a code owner October 25, 2024 12:28
@lucymhdavies lucymhdavies changed the title docs: sys/internal/counters/activity, explain deprecation for current… docs: sys/internal/counters/activity, explain deprecation for current_billing_period Oct 25, 2024
Copy link
Contributor

@miagilepner miagilepner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants