Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix open API failures for pki name constraint params #29257

Merged
merged 2 commits into from
Dec 24, 2024
Merged

UI: Fix open API failures for pki name constraint params #29257

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0994a8
add open api params
hellobontempo Dec 23, 2024
82db213
Merge branch 'main' into update-pki-params
hellobontempo Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/tests/acceptance/open-api-path-help-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ function secretEngineHelper(test, secretEngine) {
assert.deepEqual(
Object.keys(result).sort(),
Object.keys(expected).sort(),
`getProps returns expected attributes for ${modelName}`
`getProps returns expected attributes for ${modelName} (help url: "${helpUrl}")`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help url returns the open API endpoint returned which is useful for finding API docs (our ember data model names don't always map 1:1 to API resources)

);
Object.keys(expected).forEach((attrName) => {
assert.deepEqual(result[attrName], expected[attrName], `${attrName} attribute details match`);
Expand Down
49 changes: 49 additions & 0 deletions ui/tests/helpers/openapi/expected-secret-attrs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1234,6 +1234,34 @@ const pki = {
label: 'Exclude Common Name from Subject Alternative Names (SANs)',
type: 'boolean',
},
excludedDnsDomains: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'Domains for which this certificate is not allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10).',
label: 'Excluded DNS Domains',
},
excludedEmailAddresses: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'Email addresses for which this certificate is not allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10).',
label: 'Excluded email addresses',
},
excludedIpRanges: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'IP ranges for which this certificate is not allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10). Ranges must be specified in the notation of IP address and prefix length, like "192.0.2.0/24" or "2001:db8::/32", as defined in RFC 4632 and RFC 4291.',
label: 'Excluded IP ranges',
},
excludedUriDomains: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'URI domains for which this certificate is not allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10).',
label: 'Excluded URI domains',
},
format: {
editType: 'string',
helpText:
Expand Down Expand Up @@ -1312,6 +1340,27 @@ const pki = {
fieldGroup: 'default',
label: 'Permitted DNS Domains',
},
permittedEmailAddresses: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'Email addresses for which this certificate is allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10).',
label: 'Permitted email adresses',
},
permittedIpRanges: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'IP ranges for which this certificate is allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10). Ranges must be specified in the notation of IP address and prefix length, like "192.0.2.0/24" or "2001:db8::/32", as defined in RFC 4632 and RFC 4291.',
label: 'Permitted IP ranges',
},
permittedUriDomains: {
editType: 'stringArray',
fieldGroup: 'default',
helpText:
'URI domains for which this certificate is allowed to sign or issue child certificates (see https://tools.ietf.org/html/rfc5280#section-4.2.1.10).',
label: 'Permitted URI domains',
},
postalCode: {
editType: 'stringArray',
helpText: 'If set, Postal Code will be set to this value.',
Expand Down
Loading