adds tests #6937
Merged
adds tests #6937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
kalafut
approved these changes
Jun 20, 2019
ghost
pushed a commit
that referenced
this pull request
Jun 21, 2019
* Add OIDC token generation to Identity There are a few open TODOs and some remaining cleanup, but this is functionally complete and ready for review. (Tests will being added soon.) * Simplified key update endpoint * Cache the config * Fix Issuer handling * Suppose base64-encoded templates (#6919) * Cache JWKS and switch to go-cache (#6918) * Address review comments * Add warning if neither Issue nor api_addr are set * adds tests (#6937) * adds help synopsis and descriptions to the framework path for the oid… (#6930) * adds help synopsis and descriptions to the framework path for the oidc backend * Update vault/identity_store_oidc.go Co-Authored-By: Jim Kalafut <jim@kalafut.net> * Add Now parameter to PopulateStringInput * Addressing review comments * Refactor template processing to improve mode-specific handling * adds a test for the periodic func (#6943) * adds a test for the periodic func * removes commented out code * adds a comment * Add comments
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.