Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt changie for changelog generation #305

Closed
wants to merge 1 commit into from
Closed

Adopt changie for changelog generation #305

wants to merge 1 commit into from

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jun 3, 2024

This commit adds the changie tool to the repository to manage the changelog

@jpogran jpogran self-assigned this Jun 3, 2024
@jpogran jpogran changed the title changie Adopt changie for changelog generation Jun 7, 2024
This commit adds the `changie` tool to the repository to manage the changelog.
@jpogran jpogran marked this pull request as ready for review June 7, 2024 13:21
@jpogran jpogran requested a review from a team as a code owner June 7, 2024 13:21
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing this. I left some suggestions/questions

- Update README content ([#73](https://github.com/hashicorp/vscode-hcl/pull/73))
- Fix Publish Action ([#81](https://github.com/hashicorp/vscode-hcl/pull/81))

<!-- Links to tag comparisons -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of the links? And the linked headlines?

unreleasedDir: unreleased
changelogPath: CHANGELOG.md
versionExt: md
versionFormat: '## {{.Version}} ({{.Time.Format "2006-01-02"}})'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
versionFormat: '## {{.Version}} ({{.Time.Format "2006-01-02"}})'
versionFormat: '## {{.VersionNoPrefix}} ({{.Time.Format "2006-01-02"}})'

kindFormat: '{{.Kind}}:'
changeFormat: |-
* {{.Body}} ([#{{.Custom.Issue}}](https://github.com/hashicorp/{{.Custom.Repository}}/issues/{{.Custom.Issue}}))
custom:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the enum for pointing to a syntax issue here? Now, that I think about it, I think we're also missing this in vscode-terraform as well.

@jpogran jpogran closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants