Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format semantic token settings #1019

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Format semantic token settings #1019

merged 2 commits into from
Mar 30, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Mar 29, 2022

This adds a Github Action to check if there are any formatting changes to any PR submitted and ignores the package.json file when running prettier.

This is to prevent churn when adding new options to the package.json manifest.

@jpogran jpogran self-assigned this Mar 29, 2022
@jpogran jpogran added the ci Continuous integration/delivery related label Mar 29, 2022
@jpogran jpogran added this to the v2.22.0 milestone Mar 29, 2022
@jpogran jpogran requested a review from dbanck March 29, 2022 16:13
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Sometimes I dislike the formatting done by prettier, because it's less readable now

@jpogran
Copy link
Contributor Author

jpogran commented Mar 29, 2022

Same ☹️

We could try to adjust rules for json files now that we've moved syntax out...

@dbanck
Copy link
Member

dbanck commented Mar 29, 2022

Are you suggesting special rules for json files? Or have prettier ignore them?

@jpogran jpogran merged commit 6e391cd into main Mar 30, 2022
@jpogran jpogran deleted the format_semantic_tokens branch March 30, 2022 14:42
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants