Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LANGUAGE_SERVER_VERSION test in preview script #1034

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Apr 7, 2022

While testing #1032, I noticed that the test for the LANGUAGE_SERVER_VERSION variable isn't working if the variable is unset, and the script exits with an error. This PR fixes the test.

$ ./build/preview
./build/preview: line 12: LANGUAGE_SERVER_VERSION: unbound variable

@dbanck dbanck added the bug Something isn't working label Apr 7, 2022
@dbanck dbanck added this to the v2.22.0 milestone Apr 7, 2022
@dbanck dbanck self-assigned this Apr 7, 2022
@dbanck dbanck merged commit 20389f5 into main Apr 8, 2022
@dbanck dbanck deleted the b-preview-script branch April 8, 2022 12:18
@jpogran jpogran added ci Continuous integration/delivery related bug Something isn't working and removed bug Something isn't working labels Apr 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants