Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable naming convention warning for Code Action identifier #1036

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Apr 7, 2022

The Typescript naming convention does not apply to Code Action identifiers, but is being triggered here because it's being used as a object property key to update the VS Code settings in this test. This can be safely ignored.

image

The Typescript naming convention does not apply to Code Action identifiers, but is being triggerd here because it's being used as a object property key to update the VS Code settings in this test. This can be safely ignored.
@jpogran jpogran requested a review from a team April 7, 2022 13:48
@jpogran jpogran self-assigned this Apr 7, 2022
@jpogran jpogran added this to the v2.22.0 milestone Apr 7, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jpogran jpogran merged commit eeda82b into main Apr 7, 2022
@jpogran jpogran deleted the disable_naming_warning_code_action branch April 7, 2022 14:13
@github-actions
Copy link

github-actions bot commented May 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants