Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Invalid WSL Uri #1219

Merged
merged 5 commits into from
Sep 7, 2022
Merged

Handle Invalid WSL Uri #1219

merged 5 commits into from
Sep 7, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Aug 30, 2022

This adds logic to handle UNC WSL Paths that will not work in terraform-ls. It prompts the user to switch to the Remote WSL extension or allows the user to ignore the prompt.

Needs hashicorp/terraform-ls#1057 to fully function

This adds logic to handle UNC WSL Paths that will not work in terraform-ls. It prompts the user to switch to the Remote WSL extension or allows the user to ignore the prompt.
@jpogran jpogran self-assigned this Aug 30, 2022
@jpogran jpogran added the enhancement New feature or request label Aug 30, 2022
@jpogran jpogran marked this pull request as ready for review September 2, 2022 17:12
@jpogran jpogran requested a review from a team as a code owner September 2, 2022 17:12
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jpogran jpogran merged commit b8615ae into main Sep 7, 2022
@jpogran jpogran deleted the wsluri branch September 7, 2022 12:51
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants