Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vscode-languageclient to 8.1.0 #1408

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Update vscode-languageclient to 8.1.0 #1408

merged 1 commit into from
Apr 28, 2023

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Apr 28, 2023

Closes #1387

@dbanck dbanck added the dependencies Auto-pinning label Apr 28, 2023
@dbanck dbanck self-assigned this Apr 28, 2023
@dbanck dbanck requested a review from a team as a code owner April 28, 2023 09:49
radeksimko
radeksimko approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in principle LGTM, but we should carefully review the pie chart of VS Code versions folks used in the past ~30/14 days and assess the potential impact.

@dbanck
Copy link
Member Author

dbanck commented Apr 28, 2023 •
edited
Loading

I think you're referring to bumping the telemetry dependency in #1386? This PR doesn't require any engine bumps

@dbanck dbanck merged commit e326f55 into main Apr 28, 2023
@dbanck dbanck deleted the c-bump-language-client branch April 28, 2023 10:11
@radeksimko
Copy link
Member

I think you're referring to bumping the telemetry dependency in #1386? This PR doesn't require any engine bumps

Indeed, I got the two mixed up, sorry!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees

@dbanck dbanck

Labels
dependencies Auto-pinning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update vscode-languageclient to 8.1.0
2 participants
@dbanck @radeksimko