Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default activation events #1419

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented May 8, 2023

Beginning with VS Code 1.74.0, languages and commands contributed by the extension do not require a corresponding onLanguage or onCommand activation event declaration for the extension to be activated.

@jpogran jpogran self-assigned this May 8, 2023
@jpogran jpogran changed the base branch from main to f-tfc May 8, 2023 16:10
@jpogran jpogran changed the title remove default activation events Remove default activation events May 8, 2023
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, but why is this targeting f-tfc instead of main?

@jpogran jpogran changed the base branch from f-tfc to main May 9, 2023 13:07
@jpogran jpogran marked this pull request as ready for review May 9, 2023 13:09
@jpogran jpogran requested a review from a team as a code owner May 9, 2023 13:09
@jpogran
Copy link
Contributor Author

jpogran commented May 9, 2023

This LGTM, but why is this targeting f-tfc instead of main?

I forgot we upped the minimum in main and not just in the feature branch

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the extra TFC commit. Can you drop it from this branch?

Beginning with VS Code 1.74.0, languages and commands contributed by the extension do not require a corresponding onLanguage or onCommand activation event declaration for the extension to be activated.
@jpogran jpogran force-pushed the remove_default_activation_events branch from 3ae1975 to 4ebd2d7 Compare May 9, 2023 13:27
@jpogran jpogran merged commit 33bde5c into main May 9, 2023
@jpogran jpogran deleted the remove_default_activation_events branch May 9, 2023 13:32
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants