Update Node to v18 #1625
Merged
Update Node to v18 #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code ships with Electron 25 As of [v1.82], which moves the supported Node version to v18. This doesn't change our functionality, but keeps us in line with VS Code and with minimum supported versions of Node in GitHub Actions.
dbanck
reviewed
Nov 10, 2023
dbanck
reviewed
Nov 13, 2023
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code ships with Electron 25 As of v1.82, which moves the supported Node version to v18. This doesn't change our functionality, but keeps us in line with VS Code and with minimum supported versions of Node in GitHub Actions.