Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFC: Implement apply panel for structured output #1647

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Dec 5, 2023

Closes #1637

Follow-up:


UX Examples

Single panel

2023-12-05 14 55 05

Both panels

2023-12-05.14.58.20.mp4

Implementation Notes

While it may look simple and not as helpful without all the deeply structured data in the form of attributes etc. I'm afraid this is as much as we can squeeze out of the structured logs without downloading the whole plan file and rendering all the things with the full knowledge of types etc. This would be a whole different story in terms of complexity though.

I found a few bugs which affected the existing plan log, so while implementing apply log correctly I also fixed them there

  • we previously didn't ignore pending plans/applies, which have no log to offer
  • we were also trying to catch a specific axios exception related to listRuns when that methods is never actually called in the try part, it was just an earlier copy-paste error

@radeksimko radeksimko added enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor labels Dec 5, 2023
@radeksimko radeksimko force-pushed the f-tfc-apply-panel branch 4 times, most recently from e1b9475 to 52710d1 Compare December 5, 2023 15:01
@radeksimko radeksimko marked this pull request as ready for review December 5, 2023 15:05
@radeksimko radeksimko requested a review from a team as a code owner December 5, 2023 15:05
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as you link the followup tickets in the description so we know where to pickup

@radeksimko radeksimko merged commit 08a525c into main Dec 12, 2023
18 checks passed
@radeksimko radeksimko deleted the f-tfc-apply-panel branch December 12, 2023 10:07
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request terraform-cloud Features or bugs related to TFC integration in the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TFC: Reflect structured apply log in the UI
2 participants