Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve moduleProviders and moduleCalls welcome views #1676

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jan 22, 2024

This commit improves the welcome views for moduleProviders and moduleCalls by adding context variables to the views. This allows us to show different messages depending on the state of the open file inside the tree views.

@jpogran jpogran self-assigned this Jan 22, 2024
@jpogran jpogran force-pushed the tf_module_welcome_view_clauses branch from 10b1ab2 to 4bf409d Compare January 22, 2024 15:06
@jpogran jpogran marked this pull request as ready for review January 22, 2024 15:17
@jpogran jpogran requested a review from a team as a code owner January 22, 2024 15:17
@jpogran jpogran linked an issue Jan 22, 2024 that may be closed by this pull request
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This is a nice improvement over the current state.

I noticed that when there is no LS running (disabled or on the web) that the message defaults to "There are no open Terraform files [...]". Do we want to improve the message for this case as well?

package.json Outdated Show resolved Hide resolved
src/providers/moduleCalls.ts Show resolved Hide resolved
src/providers/moduleProviders.ts Show resolved Hide resolved
src/providers/moduleProviders.ts Outdated Show resolved Hide resolved
src/providers/moduleCalls.ts Outdated Show resolved Hide resolved
jpogran and others added 3 commits February 7, 2024 11:48
This commit improves the welcome views for moduleProviders and moduleCalls by adding context variables to the views. This allows us to show different messages depending on the state of the open file inside the tree views.
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
@jpogran jpogran force-pushed the tf_module_welcome_view_clauses branch from ac5a596 to a38181c Compare February 7, 2024 16:48
@jpogran
Copy link
Contributor Author

jpogran commented Feb 7, 2024

I noticed that when there is no LS running (disabled or on the web) that the message defaults to "There are no open Terraform files [...]". Do we want to improve the message for this case as well?

I added another clause with a new command that will open the settings window (either UI or JSON) with the relevant setting highlighted and ready to edit when this occurs.

@jpogran jpogran requested a review from dbanck February 7, 2024 17:02
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for going the extra mile and adding a button! I like the UX.

package.json Outdated Show resolved Hide resolved
src/commands/terraformls.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jpogran jpogran merged commit bbd86a9 into main Feb 8, 2024
18 checks passed
@jpogran jpogran deleted the tf_module_welcome_view_clauses branch February 8, 2024 17:23
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Module Calls and Providers Welcome View
2 participants