-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme: Correct supported list of extensions #420
Conversation
This got caught in an in-between state: the syntax highlighting file will apply itself to .hcl files if the Terraform extension is already loaded. If we want to 100% ignore all .hcl then the file header in |
If you see #225, we mark Terraform content as |
I just thought it's easier not to support it initially, because if we are going to highlight I suspect people won't download Terraform extension to get highlighting for generic HCL, but also they might have Terragrunt configs alongside Terraform, which are generic HCL and should be highlighted as such. I understand the pragmatic argument that most of our docs use hcl identifier in markdown and all of these docs do contain Terraform, but also they use wrong identifier, so we will need to address that tech debt sooner or later. I guess it comes down to comparing the cost of:
It seems there's perception that (1) has the lowest cost, which I'm happy to respect, but I wanted to make sure we are all making an informed decision 😉 |
i load outputs of terraform runs into vscode to read them, and those are HCL highlighted |
and then there's this |
@aeschright is something blocks from merging? |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Looks like this was just a relic from the older version of the extension. Generally
hcl
represents generic HCL configuration, not something Terraform would ever load.That said it's something we may consider supporting in the future either directly or via a separate extension and/or separate language server.
For now not supporting HCL in a Terraform extension is intentional.
Relatedly if any other Terraform extension supports HCL and treats it the same way as Terraform's HCL, it's probably inaccurate. Many extensions aren't currently aware of this distinction and that's something we also need to communicate going forward, as per hashicorp/terraform-ls#50 (comment)